complete assignment#37
Open
wypythonbasic wants to merge 1 commit intomodern-web-application-uw19:masterfrom
Open
complete assignment#37wypythonbasic wants to merge 1 commit intomodern-web-application-uw19:masterfrom
wypythonbasic wants to merge 1 commit intomodern-web-application-uw19:masterfrom
Conversation
MadEste
reviewed
May 10, 2019
|
|
||
| // Export class here | ||
| module.exports = {}; | ||
| render() { |
There was a problem hiding this comment.
Rather than redo the render function you can leverage the parent class and its functions.
MadEste
reviewed
May 10, 2019
| // Define class here | ||
| class DivElement extends HTMLElement { | ||
| constructor(content) { | ||
| super(); |
There was a problem hiding this comment.
You can pass the parameters into super to use the parents constructor to set them. ie:
super('div', content);
|
Good work, be sure you understand how super() works so you can utilize it and avoid duplicate code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Week 1 HW Submission
Please fill out the information below in order to complete your assignment. Feel free to update this comment later if necessary.