Fix inconsistent PAT display order #4662
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IMB11
approved these changes
Oct 29, 2025
|
please run pnpm fix:frontend to fix the lint issues |
|
oh actually, this is failing because the computed has a side effect because .sort() mutates the original array |
Prospector
requested changes
Oct 29, 2025
| const { data: pats, refresh } = await useAsyncData('pat', () => useBaseFetch('pat')) | ||
| const displayPats = computed(() => { | ||
| return pats.value.sort((a, b) => new Date(b.created) - new Date(a.created)) |
There was a problem hiding this comment.
sort mutates pats array, computeds shouldn't have side effects like that
There was a problem hiding this comment.
Yeah, you're right, I forgot sort mutated the array instead of copying it
Prospector
added
website
auto-merge was automatically disabled
October 30, 2025 03:54
Head branch was pushed to by a user without write access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4661
This fixes the Personal access tokens list under Settings > Personal Access Tokens to display the PATs in order of creation, instead of being in a random order every page load.