fix(build): ensure 'desc' key exists in snippet and source properties#127
Open
Ibochkarev wants to merge 1 commit intobetafrom
Open
fix(build): ensure 'desc' key exists in snippet and source properties#127Ibochkarev wants to merge 1 commit intobetafrom
Ibochkarev wants to merge 1 commit intobetafrom
Conversation
- Add default empty 'desc' for source properties in resolver_04_sources - Add default empty 'desc' for snippet properties in resolver_08_snippet_properties - Fix currentDesc reading from updated properties array in resolver_08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание
Исправление ошибок при сборке пакета, когда у свойств сниппетов и источников отсутствует ключ
desc. Добавлена инициализация пустой строки дляdesc, если ключ отсутствует в определении свойства.Тип изменений
Связанные Issues
https://modx.pro/components/25458#comment-146331
Как это было протестировано?
Изменения:
resolver_04_sources.php: добавлена проверка и инициализацияdescдля свойств источниковresolver_08_snippet_properties.php: добавлена проверкаarray_key_exists('desc')перед обращением к ключу, исправлено чтениеcurrentDescиз обновлённого массива$propertiesСкриншоты (если применимо)
Не применимо.
Чеклист
Дополнительные заметки
Исправление предотвращает предупреждения/ошибки при
array_key_existsи обращении к несуществующему ключуdescв определениях свойств.