Skip to content

Fix Ditto TV inheritance processing by setting docid #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yama merged 3 commits into from
Feb 3, 2026
+17 −10
Merged

Fix Ditto TV inheritance processing by setting docid #385

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
85d6b84
Fix Ditto TV processing docid for inheritance
yama Jan 22, 2026
029de30
Refactor Ditto appendTV TV assignment handling
yama Jan 22, 2026
3f605c5
Refactor Ditto appendTV to use helper method
yama Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 17 additions & 10 deletions assets/snippets/ditto/classes/ditto.class.inc.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -830,10 +830,7 @@ function appendTV($tvname = '', $docIDs=[])
$total = db()->count($rs);
$docs = [];
while ($row = db()->getRow($rs)) {
$k = '#' . $row['contentid'];
$v = evo()->tvProcessor($row);
$docs[$k][$row['name']] = $v;
$docs[$k]['tv' . $row['name']] = $v;
$this->appendTvValue($docs, $row, $row['contentid'], $row['name']);
}
if ($total == count($docIDs)) {
return $docs;
Expand All @@ -853,9 +850,7 @@ function appendTV($tvname = '', $docIDs=[])
$k = '#' . $id;
if (!isset($docs[$k])) {
$row['contentid'] = $id;
$v = evo()->tvProcessor($row);
$docs[$k][$tvname] = $v;
$docs[$k]['tv' . $tvname] = $v;
$this->appendTvValue($docs, $row, $id, $tvname);
}
}
return $docs;
Expand All @@ -868,13 +863,25 @@ function appendTV($tvname = '', $docIDs=[])
if (isset($docs[$k])) {
continue;
}
$v = evo()->tvProcessor($row);
$docs[$k][$tvname] = $v;
$docs[$k]['tv' . $tvname] = $v;
$this->appendTvValue($docs, $row, $id, $tvname);
}
return $docs;
}

// ---------------------------------------------------
// Function: appendTvValue
// Append processed TV output to documents array
// ---------------------------------------------------

function appendTvValue(&$docs, $row, $contentId, $name)
{
$k = '#' . $contentId;
$row['docid'] = $contentId;
$v = evo()->tvProcessor($row);
$docs[$k][$name] = $v;
$docs[$k]['tv' . $name] = $v;
}

// ---------------------------------------------------
// Function: appendKeywords
// Append keywords's to the resource array
Expand Down