Skip to content

feat: add notification toggle and bump version to 1.5.0#35

Merged
moheladwy merged 1 commit intomainfrom
feat/notification-toggler
Mar 28, 2026
Merged

feat: add notification toggle and bump version to 1.5.0#35
moheladwy merged 1 commit intomainfrom
feat/notification-toggler

Conversation

@moheladwy
Copy link
Copy Markdown
Owner

- Add -n/--notify flag to OCR4Linux.sh to enable desktop notifications.
- Bump version to 1.5.0 across OCR4Linux.py, OCR4Linux.sh, and PKGBUILD.
- Add libnotify dependency to PKGBUILD.
- Update README.md with new usage instructions and installation options.
@moheladwy moheladwy self-assigned this Mar 27, 2026
@moheladwy moheladwy added documentation Improvements or additions to documentation enhancement New feature or request new feature labels Mar 27, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 27, 2026

📝 Walkthrough

Summary by CodeRabbit

Release Notes – Version 1.5.0

  • New Features

    • Added --notify flag to display desktop notifications after screenshot capture.
  • Documentation

    • Updated installation instructions to clarify AUR and build-from-source methods.
    • Updated usage examples to reflect new command-line invocation style.
  • Chores

    • Version bumped to 1.5.0.
    • Added libnotify as a required system dependency.

Walkthrough

This PR bumps the project version to 1.5.0 across all components and introduces a new -n | --notify flag to control desktop notifications for screenshot operations. The change adds libnotify as a dependency and updates installation and usage documentation to reflect AUR/makepkg patterns.

Changes

Cohort / File(s) Summary
Version Bumps
OCR4Linux.py, OCR4Linux.sh, PKGBUILD, setup.sh, README.md
Updated version metadata from 1.4.2 to 1.5.0 across all files, including header comments and package version generation.
Notification Feature & Dependencies
OCR4Linux.sh, PKGBUILD, setup.sh
Added -n / --notify flag logic to control screenshot notifications in Wayland (grimblast) and X11 (notify-send) environments; added libnotify to package and system dependencies.
Documentation Updates
README.md
Expanded installation instructions (AUR/makepkg emphasis, build-from-source alternatives), updated usage examples to reference OCR4Linux binary, documented new --notify option, and revised keyboard shortcut examples for Hyprland and dwm.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

🐰 A notification hops along,
Version bumps grow strong and long,
With flags to show or hide,
A rabbit's joy, screenshot with pride! 📸✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the two main changes: adding a notification toggle feature and bumping the version to 1.5.0, which align with the changeset modifications.
Description check ✅ Passed The description is directly related to the changeset, covering the notification flag addition, version bump, dependency addition, and documentation updates.
Linked Issues check ✅ Passed The PR successfully implements issue #34 by adding a -n/--notify flag to control notifications in both Wayland (grimblast) and X11 (notify-send) screenshot capture methods.
Out of Scope Changes check ✅ Passed All code changes are directly related to issue #34 objectives: notification toggle implementation, version bumping, dependency management, and documentation updates are all in-scope and justified.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/notification-toggler

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning

CodeRabbit couldn't request changes on this pull request because it doesn't have sufficient GitHub permissions.

Please grant CodeRabbit Pull requests: Read and write permission and re-run the review.

👉 Steps to fix this

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@README.md`:
- Around line 129-143: The fenced code blocks in README.md around the three
launch examples (the blocks containing "OCR4Linux",
"~/.config/OCR4Linux/OCR4Linux.sh", and "./OCR4Linux.sh") lack blank lines
before and/or after them; update the file so there is an empty line immediately
before each opening ```sh fence and an empty line immediately after each closing
``` fence to satisfy markdown linting and ensure correct rendering.
- Around line 297-325: The two indented headings "### Example for `Hyprland`
users:" and "### Example for `dwm` users:" are causing markdownlint warnings;
remove the leading spaces so the headings start at column 0 (or alternatively
replace them with bold text like **Example for `Hyprland` users:** and **Example
for `dwm` users:** if you want to keep indentation), and ensure any other nearby
headings in the same block follow the same pattern so markdownlint stops
flagging them.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: c66f0f13-8702-487c-bae2-52524088167c

📥 Commits

Reviewing files that changed from the base of the PR and between 0ef3354 and 1e55f08.

📒 Files selected for processing (5)
  • OCR4Linux.py
  • OCR4Linux.sh
  • PKGBUILD
  • README.md
  • setup.sh

@moheladwy moheladwy merged commit a551094 into main Mar 28, 2026
7 checks passed
@moheladwy moheladwy deleted the feat/notification-toggler branch March 28, 2026 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a flag for disabling and enabling the notifications for grimblast in the Wayland session

1 participant