Add support for embedded refunds in payment object #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@justincase can you take a look? 🙏🏼 Otherwise I will first create a monkey patch in our own code to make this happen. |
Collaborator
|
@MathijsK93 Thanks! I'll take a look, likely next week. |
Contributor
Author
|
Friendly bump 😃 |
Collaborator
|
Thanks, I'll add the other embedded resources and publish a new version. 👍 |
Collaborator
|
Added to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the API it's possible to embed refunds, so it's not necessary to do another request for them. In this PR I'm adding support for using this embedded refunds when doing something like
payment.refunds.The same needs to be done for chargebacks and captures. Maybe someone can help with adding those resources to
test/fixtures/payments/get_embedded_resources.json