This repository was archived by the owner on May 17, 2021. It is now read-only.
fix: prevent mouse cursor jumping COMPASS-4432 #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
approved these changes
Mar 16, 2021
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
Just to make sure I understand, this works because mouseTargetEnter refers to the freshly appended rect and not the one pointed to by mouseTarget, right?
Member
Author
|
@addaleax - Yes, it looks like that's what was causing the issue. Looks like this fix might cause an issue with cloud though - I think this issue came up as a result to the changes from here #33 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMPASS-4432
Quick fix so that it only registers mouse events that occur inside the mouse target area. We could probably do something more fancy, but I'm not sure we want to invest the time right now.
Here's what it looks like now:
cursor.not.glitching.mp4