Conversation
hschawe
left a comment
There was a problem hiding this comment.
i've got a couple questions before approving
| You may use the available tools to help you explore the database, generate the query, think about the problem, and submit the final solution. | ||
| const tools = `<tools> | ||
|
|
||
| <tool name="${thinkToolName}"> |
There was a problem hiding this comment.
have you noticed any performance loss in tool calling for non-gpt models after removing the tool descriptions here?
There was a problem hiding this comment.
i haven't no, but also havent specifically looked into that
There was a problem hiding this comment.
since the "tool instructions in tool description" guidance came from openai, i'm concerned that this change could cause performance losses in non-gpt models that's unrelated to the "mongodb knowledge" of those models. something to keep in mind when running these benchmarks in the future
There was a problem hiding this comment.
yea valid point. worth measuring (in the future)
There was a problem hiding this comment.
like we could be stacking the deck in openai's favor w/ this approach
| @@ -131,7 +131,6 @@ export async function makeMongoDbMcpAgent({ | |||
| mcpToolSet[thinkToolName] = thinkTool; | |||
There was a problem hiding this comment.
do you think we should exclude this when using reasoning models?
There was a problem hiding this comment.
no, i think it sohuld be kept 1. for consistency and 2. b/c the reasoning model might still derive value from explicitly writing thoughts out (this was mentioned as useful in a blog post i read)
| systemPrompt: atlasSearchAgentPromptWithOptimizedRecommendation, | ||
| maxSteps: ATLAS_SEARCH_AGENT_MAX_STEPS, | ||
| mongoClient, | ||
| mongoDbMcpClient: mcpClient, |
There was a problem hiding this comment.
nitpick-y but consider renaming mcpClient as mongoDbMcpClient for simplicity
Jira: https://jira.mongodb.org/browse/EAI-1237
Changes
Notes