Skip to content

Correct embedded model SchemaTests #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
timgraham wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Correct embedded model SchemaTests #467

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 8 additions & 14 deletions tests/schema_/test_embedded_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ class Meta:
def test_constraints(self):
"""Meta.constraints on an embedded model."""

class Address(models.Model):
class Address(EmbeddedModel):
unique_constraint_one = models.CharField(max_length=10)

class Meta:
Expand All @@ -237,7 +237,7 @@ class Meta:
models.UniqueConstraint(fields=["unique_constraint_one"], name="unique_one")
]

class Author(models.Model):
class Author(EmbeddedModel):
address = EmbeddedModelField(Address)
unique_constraint_two = models.CharField(max_length=10)

Expand Down Expand Up @@ -331,15 +331,15 @@ class Meta:
def test_add_remove_field_unique_together(self):
"""AddField/RemoveField + EmbeddedModelField + Meta.unique_together."""

class Address(models.Model):
class Address(EmbeddedModel):
unique_together_one = models.CharField(max_length=10)
unique_together_two = models.CharField(max_length=10)

class Meta:
app_label = "schema_"
unique_together = [("unique_together_one", "unique_together_two")]

class Author(models.Model):
class Author(EmbeddedModel):
address = EmbeddedModelField(Address)
unique_together_three = models.CharField(max_length=10)
unique_together_four = models.CharField(max_length=10)
Expand All @@ -349,8 +349,6 @@ class Meta:
unique_together = [("unique_together_three", "unique_together_four")]

class Book(models.Model):
author = EmbeddedModelField(Author)

class Meta:
app_label = "schema_"

Expand Down Expand Up @@ -400,14 +398,14 @@ class Meta:
def test_add_remove_field_indexes(self):
"""AddField/RemoveField + EmbeddedModelField + Meta.indexes."""

class Address(models.Model):
class Address(EmbeddedModel):
indexed_one = models.CharField(max_length=10)

class Meta:
app_label = "schema_"
indexes = [models.Index(fields=["indexed_one"])]

class Author(models.Model):
class Author(EmbeddedModel):
address = EmbeddedModelField(Address)
indexed_two = models.CharField(max_length=10)

Expand All @@ -416,8 +414,6 @@ class Meta:
indexes = [models.Index(fields=["indexed_two"])]

class Book(models.Model):
author = EmbeddedModelField(Author)

class Meta:
app_label = "schema_"

Expand Down Expand Up @@ -459,7 +455,7 @@ class Meta:
def test_add_remove_field_constraints(self):
"""AddField/RemoveField + EmbeddedModelField + Meta.constraints."""

class Address(models.Model):
class Address(EmbeddedModel):
unique_constraint_one = models.CharField(max_length=10)

class Meta:
Expand All @@ -468,7 +464,7 @@ class Meta:
models.UniqueConstraint(fields=["unique_constraint_one"], name="unique_one")
]

class Author(models.Model):
class Author(EmbeddedModel):
address = EmbeddedModelField(Address)
unique_constraint_two = models.CharField(max_length=10)

Expand All @@ -479,8 +475,6 @@ class Meta:
]

class Book(models.Model):
author = EmbeddedModelField(Author)

class Meta:
app_label = "schema_"

Expand Down