Skip to content

Conversation

@connorsmacd
Copy link
Collaborator

@connorsmacd connorsmacd commented Oct 20, 2025

References

CDRIVER-6104
DRIVERS-3294
MONGOCRYPT-793

Summary

MONGOCRYPT-793 adds support for mixing QE and CSFLE schemas. This implicates the CSE $lookup prose tests in two ways:

  • For prose test 8, the expected error message substring now depends on both the version of crypt_shared/mongocryptd and libmongocrypt.
  • There is a new prose test (10) that evaluates the happy path when QE is mixed with a non-CSFLE JSON schema.

Version of libmongocrypt

The behavior of prose test 8 is now conditioned on the version of libmongocrypt. As part of the spec change, there are two POC draft PRs that demonstrate passing tests pre and post 1.17:

That said, this PR makes no changes to the EVG config, so it will still use 1.15.1. This does mean that only the <1.17 codepath will be tested in EVG. If we wanted to ensure that all paths are tested, we would need multiple CI runs that each use different libmongocrypt versions.

@connorsmacd connorsmacd changed the title CDRIVER-6104 Update CLE prose tests for libmongocrypt 1.17 CDRIVER-6104 Update CSE prose tests for libmongocrypt 1.17 Oct 22, 2025
@connorsmacd connorsmacd marked this pull request as ready for review October 22, 2025 18:56
@connorsmacd connorsmacd requested a review from a team as a code owner October 22, 2025 18:56
@connorsmacd connorsmacd requested a review from kevinAlbs October 22, 2025 18:56
Copy link
Collaborator

@kevinAlbs kevinAlbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM!

@connorsmacd connorsmacd merged commit 38e3093 into mongodb:master Oct 23, 2025
44 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants