RUBY-3620 - Sessions should ignore "cluster mismatched" validation and execute commands on other clusters #2918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cute without error
johnnyshields
changed the title
johnnyshields
changed the title
johnnyshields
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per RUBY-3620, when using a Session transaction, currently, it is impossible to execute any command on any other cluster. This is a big problem if you have model callbacks which are cross-cluster--your app fails and there's nothing you can do about it 🤦♂️
At a minimum, it is better to allow cross-cluster commands to execute within transactions, i.e. on a separate session for that cluster.
In the future (not in this PR), we could allow:
Note that this PR introduces/extracts out SessionClusterMismatched error (base class SessionInvalid)