WIP: upgrade to driver v2 #868
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that nothing here will compile yet.
Note that nothing here will compile yet.
mmcclimon
force-pushed
the
driver-v2
branch
5 times, most recently
from
d50d87d to
24b6094
Compare
This should fix a lot of the compilation errors, but not all of them.
I still need to figure out what to do with wtimeout here.
The gridfs package is now part of the mongo package and has slightly different interfaces.
This change from int to float is dubious.
Still todo: WTimeout.
As suspected, this didn't work at all!
Driver v2 decodes to bson.D by default, and the tests expect a bson.M instead.
These can only error if you pass them the wrong type of something, so we'll just panic here.
This failed in CI while I was testing these changes; it's unrelated to the driver v2 stuff, but I might as well fix it while I'm here.
This is step one to having a useful wtimeout option.
Nothing is using this yet.
This means that we can get the correct WTimeout behavior.
That is: the SBOM, the SARIF report, and the third-party notices file.
Maybe this will work, and maybe it won't!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[to come]