Open
Conversation
My build continued after wrong parameters which of course ended up in a harder to correlate failure later in the build. Fail early would have saved me some time debugging.
Contributor
|
@ronaldklop Hi Ronald, thanks for submitting this PR. Exiting 1 there is definitely an improvement. Before we can accept this contribution, could I trouble you to sign this contributor's agreement? https://www.mongodb.com/legal/contributor-agreement Once you sign it, I will merge your change internally. Shortly after it merges, the commit will be mirrored here on |
Contributor
|
Oops, I see that the contributor agreement has already been signed. I will see that this gets merged in shortly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My build continued after wrong parameters which of course ended up in a harder to correlate failure later in the build. Fail early would have saved me some time debugging.
Anything in this description will be included in the commit message. Replace or delete this text before merging. Add links to testing in the comments of the PR.