DRIVERS-3218 Avoid clearing the connection pool when the server connection rate limiter triggers #1855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ction rate limiter triggers
blink1073
requested review from
BorisDog and
ShaneHarvey
and removed request for
a team
4 tasks
blink1073
commented
Nov 11, 2025
| data: | ||
| failCommands: ["isMaster","hello"] | ||
| closeConnection: true | ||
| blockConnection: true |
Member
Author
There was a problem hiding this comment.
While we are discouraged from changing existing tests, these test still pass without the backpressure changes, and this avoids adding a new runOnRequirement.
ShaneHarvey
reviewed
Nov 12, 2025
| - **Backpressure-enabled** - The pool MUST add the error labels `SystemOverloadedError` and `RetryableError` to network | ||
| errors or network timeouts it encounters during the connection establishment or the `hello` message. These labels | ||
| are used by the | ||
| [server monitor](../server-discovery-and-monitoring/server-discovery-and-monitoring.md#error-handling-pseudocode) to |
Member
There was a problem hiding this comment.
Suggest [server monitor] -> [SDAM error handling]
"server monitor" is the title of another document.
|
|
||
| 1. Two concurrent writes begin on application threads A and B. | ||
| 2. The server restarts. | ||
| 3. Thread A receives the first non-timeout network error, and the client marks the server Unknown, and clears the |
Member
There was a problem hiding this comment.
Does this section need to change? We aren't changing the behavior of network errors when executing a command.
nhachicha
reviewed
Nov 14, 2025
| - isMaster | ||
| - hello | ||
| appName: backpressureNetworkErrorFailTest | ||
| closeConnection: true |
Contributor
There was a problem hiding this comment.
Aren't we missing
Suggested change
| closeConnection: true | |
| closeConnection: true | |
| errorLabels: | |
| - SystemOverloadedError | |
| - RetryableError |
Member
Author
There was a problem hiding this comment.
No, the labels are expected to be added by the client in this case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #1852
Please complete the following before merging:
clusters).