Skip to content

Failing specs for embedded doc position updating #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
johnnyshields wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Failing specs for embedded doc position updating #87

johnnyshields wants to merge 1 commit into from

Conversation

@johnnyshields
Copy link
Member

@johnnyshields johnnyshields commented Nov 7, 2023 •
edited
Loading

This PR currently demonstrates divergent behavior where the following are not equivalent on embedded docs:

# this correctly preserves order
embedded_doc.move_to(2)
embedded_doc.save!

# this does NOT preserve order and just literally sets the position field
embedded_doc.position = 2
embedded_doc.save!

This behavior does work correctly on non-embedded docs.

(TBD: perhaps we need an option to preserve legacy direct position setting behavior, but i doubt it...)

@johnnyshields johnnyshields mentioned this pull request Nov 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@johnnyshields