Skip to content

Wrap enqueueOperation in a try-catch #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Wrap enqueueOperation in a try-catch #61

wants to merge 1 commit into from

Conversation

@lloydmeta
Copy link
Collaborator

@lloydmeta lloydmeta commented Apr 29, 2018

Closes #60

  • Move mconn.enqueueOperation into prepareFuture and wrap it in
    try-catch because it can fail. On failure, complete the future
    with a failure, passing it the caught Throwable

@lloydmeta
* Move mconn.enqueueOperation into prepareFuture and wrap it in
c5b93eb 
  try-catch because it can fail. On failure, complete the future
  with a failure, passing it the caught Throwable
@lloydmeta lloydmeta requested review from alexandru and aoprisan April 29, 2018 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexandru alexandru Awaiting requested review from alexandru

@aoprisan aoprisan Awaiting requested review from aoprisan

Assignees

No one assigned

Labels

bug enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@lloydmeta