Fixed a byte order bug in BrowseService.cs.

[sjvanrossum]

Changed BrowseService.cs due to recent changes in byte order handling.
Port numbers returned by resolved services should now be correct.

[sjvanrossum]

This Gist demonstrates the correctness of the commit in this pull request, when you run it on the current master branch of mono/Mono.ZeroConf.
Which should output something like this on a succesful runthrough:

Service registered at port 80.
Resolved port as 20480, without NetworkToHostOrder.
Resolved port as 80, with NetworkToHostOrder.

Also, here's an example from a MZClient query to my Bonjour printer advertising a _http._tcp service on port 80.

mono/Mono.Zeroconf output:

Hit ^C when you're bored waiting for responses.

*** Found name = 'Photosmart 3300 series [401F97]', type = '_http._tcp.', domain = 'local.'
*** Resolved name = 'Photosmart\0323300\032series\032[401F97]._http._tcp.local.', host ip = '10.0.0.3', hostname = , port = '20480', interface = '10', address type = 'Any', TXT Record = [ = '']

JvetS/Mono.Zeroconf output:

Hit ^C when you're bored waiting for responses.

*** Found name = 'Photosmart 3300 series [401F97]', type = '_http._tcp.', domain = 'local.'
*** Resolved name = 'Photosmart\0323300\032series\032[401F97]._http._tcp.local.', host ip = '10.0.0.3', hostname = , port = '80', interface = '10', address type = 'Any', TXT Record = [ = '']

[jasoncouture]

This issue still exists, I cloned master after numerous issues with the nuget package. I have to change the byte order, I applied the fixes in this pull request and the issue was resolved.

[yanhkim]

👍

[piedar]

Nuget package is still broken, 3.5 years after this one-line patch was suggested.

[sjvanrossum]

I've sent out an email to Aaron. I was surprised to see this PR still hasn't been closed after 4 years.

[Lakritzator]

I also wanted to use this library, but with all the PRs still open it seems a bit old...

[Sobia01]

Cannot use port valuer overflow Int16. Any solution?

[piedar]

For those seeking alternatives: I've had success with Tmds.MDns, which is standalone (no Bonjour or Avahi) and actually works.

[Sobia01]

Hi, I am using Mono.Zeroconf. I have an issue of using port values larger then Int16. Do anyone know the solution? I want to use port value = 65535, also unchecked (Short) can't work for me. I can register using uPort but i couldn't resolve service port because i can't use uPort in Resolve service. Link : https://github.com/eaglemc/Mono.Zeroconf/tree/9076cdd0ae1af82f8f7e788955018 http://www.mono-project.com/archived/monozeroconf/ Please Help ! Regards *Sobia Rind*

…

On Fri, Jun 16, 2017 at 2:26 AM, piedar ***@***.***> wrote: For those seeking alternatives: I've had success with Tmds.MDns <https://github.com/tmds/Tmds.MDns>, which is standalone (no Bonjour or Avahi) and actually works. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#4 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AVeSfYMva3fGN0K4Uv9BVtf-h-R8gzK6ks5sEWkvgaJpZM4A5ICn> .