Skip to content

31 Fix: Inclusion using class naming deprecated#33

Open
leonstr wants to merge 1 commit intomoodleou:mainfrom
leonstr:31-inclusiondeprecated
Open

31 Fix: Inclusion using class naming deprecated#33
leonstr wants to merge 1 commit intomoodleou:mainfrom
leonstr:31-inclusiondeprecated

Conversation

@leonstr
Copy link

@leonstr leonstr commented Nov 5, 2024

Reflect Moodle 4.5's changes to Filter API (MDL-82427).

Reflect Moodle 4.5's changes to Filter API (MDL-82427).

Co-authored-by: lkcivan <ivan.lam@ucl.ac.uk>
@dmitriim
Copy link

dmitriim commented Feb 18, 2025

Can confirm that this fixes the issue on Moodle 4.5.

@ziegenberg
Copy link

Hi @timhunt!
Any chance we can get this merged soon?
Greetings,
Daniel

@ziegenberg
Copy link

Hi @leonstr,

the following three files include the old filter.php class file. Do they need updating too?

  • classes/question_options.php:29 ?require_once($CFG->dirroot . '/filter/embedquestion/filter.php');
  • tests/filter_test.php:22 require_once($CFG->dirroot . '/filter/embedquestion/filter.php');
  • tests/utils_test.php:22 require_once($CFG->dirroot . '/filter/embedquestion/filter.php');

@AnupamaSarjoshi AnupamaSarjoshi force-pushed the main branch 2 times, most recently from 370ff7f to 72c157f Compare May 1, 2025 18:53
@aspark21
Copy link

looks like this was included in 9a62735 but not the change to the attempt test - https://github.com/moodleou/moodle-filter_embedquestion/pull/33/files#diff-d64bca6c1dcf7259558d3afb224094e1cad7185c073f11b8a8140b43c843c6caR278 - not sure how significant that was

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants