Fixes for running ci against main Moodle branch#37
Open
danowar2k wants to merge 9 commits intomoodleou:mainfrom
Open
Fixes for running ci against main Moodle branch#37danowar2k wants to merge 9 commits intomoodleou:mainfrom
danowar2k wants to merge 9 commits intomoodleou:mainfrom
Conversation
370ff7f to
72c157f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I forked the plugin to check for the combination of PHP 8.1 and Moodle 4.1 compatibility. I had to fix a few things while doing this:
I also changed:
Anyway, one Behat test is still failing (https://github.com/danowar2k/moodle-filter_embedquestion/actions/runs/12836059633/job/35796878521#step:17:173).
If I knew the plugins in question I'd probably be able to see what's happening there. Or if I'd have screenshots, but at the moment I don't have local Behat/Selenium/etc. set up.
Anyway, maybe the fixes help....