Open
Conversation
Member
|
Have to say, Just do Expand all, an then Find in page. |
Author
|
Fewer clicks (I'm lazy) and closes categories with no matching entries (easier to scan read). Give it a go, you might like it. |
Member
|
Sorry, I can see now that my comment probably came across as dismissive, which we not my intention. This is a good feature proposal. Just need to get code, and pull request/git history, which is clean. |
Author
|
Thanks Tim. The failing check seems to be more a ci.yml thing (wrong version of postgres). I think that's probably better to fix outside this pull request. Before I do any squashing, is there anything you'd want me to change? I will remove the hard-coding "Search queries..." string. |
sharpchi
force-pushed
the
searchqueries
branch
2 times, most recently
from
4c09172 to
cd1ef91
Compare
Author
|
Hi @timhunt, that's all squashed up and ready to roll. |
Remove unnecessary comma Language string Don't need require for reportsearch in index_page
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds client-side filtering of queries for issue #163