Added wait_for_nothing_visible_to_be_animating for UIRefreshControl animation issue#273
Open
samst0r wants to merge 1 commit intomoredip:masterfrom
Open
Added wait_for_nothing_visible_to_be_animating for UIRefreshControl animation issue#273samst0r wants to merge 1 commit intomoredip:masterfrom
wait_for_nothing_visible_to_be_animating for UIRefreshControl animation issue#273samst0r wants to merge 1 commit intomoredip:masterfrom
Conversation
…for views that are animating and are also `FEX_isVisible`. This resolves the issues with the UIRefreshControl (Issue moredip#266).
Contributor
|
+1 to this. |
Owner
|
Thanks for the contribution. I'm not sure I like the approach of making two separate Could you approach this by adding an |
Author
|
No worries. I'll go ahead and add that into ObjC side. That's a good shout. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
wait_for_nothing_visible_to_be_animatinghelper method which checks for views that are animating and are alsoFEX_isVisible.This resolves the issues with the UIRefreshControl (Issue #266).