Skip to content

Fix cache lock file name bug#965

Merged
XiaohanZhangCMU merged 2 commits intomainfrom
xiaohan/fix-cache_filelocks
Jan 22, 2026
Merged

Fix cache lock file name bug#965
XiaohanZhangCMU merged 2 commits intomainfrom
xiaohan/fix-cache_filelocks

Conversation

@XiaohanZhangCMU
Copy link
Collaborator

@XiaohanZhangCMU XiaohanZhangCMU commented Jan 21, 2026

Description of changes:

Issue #, if available:

Merge Checklist:

Put an x without space in the boxes that apply. If you are unsure about any checklist, please don't hesitate to ask. We are here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the contributor guidelines
  • This is a documentation change or typo fix. If so, skip the rest of this checklist.
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the MosaicML team.
  • I have updated any necessary documentation, including README and API docs (if appropriate).

Tests

  • I ran pre-commit on my change. (check out the pre-commit section of prerequisites)
  • I have added tests that prove my fix is effective or that my feature works (if appropriate).
  • I ran the tests locally to make sure it pass. (check out testing)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes.

Copy link

@bowenyang008 bowenyang008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@XiaohanZhangCMU XiaohanZhangCMU merged commit 4de3acb into main Jan 22, 2026
7 checks passed
@XiaohanZhangCMU XiaohanZhangCMU deleted the xiaohan/fix-cache_filelocks branch January 22, 2026 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: CACHE_FILELOCK attribute check always fails due to attribute name mismatch

2 participants