Handle case of not setting options; do not return options we don't set#39
Open
edestecd wants to merge 1 commit intomosen:masterfrom
Open
Handle case of not setting options; do not return options we don't set#39edestecd wants to merge 1 commit intomosen:masterfrom
edestecd wants to merge 1 commit intomosen:masterfrom
Conversation
Owner
|
Hey there, |
Owner
|
FYI: Setting up OSX beaker test to repeat the issue as it isnt replicated on CentOS. Should be able to find some middle ground. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On OSX machines I have tested:
lib/puppet/provider/printer/cups.rb: blows up about calling include? on nil when you don't set options.
AND
Continues to try and set every possible option listed by lpoptions -l instead of just the options you pass as a hash.
This fixes both of those by putting back some code that was removed in the past.
I copied it, more or less, from the 1.3.0 branch.