Make default printer an exec configured w/ a param#57
Merged
mosen merged 4 commits intomosen:masterfrom Sep 2, 2015
Merged
Conversation
This makes several changes to clean up the Puppet code. With this it mostly pass puppet-lint using the default settings, inherits from params notwithstanding. It also tabularizes key/value pair lists, removes some blank lines and makes variable scope explicit.
Contributor
Author
|
Refs #41 |
This removes the `default_printer` type and provider and makes it an exec instead, fed by a parameter to the init class. Using an exec like this ensure the attribute remains singleton.
This adds an empty hash to the `hiera_hash()` printer lookup to prevent an error in case Hiera cannot find any printers.
This creates a `hiera_hash()` lookup for the `printer_defaults` type, similar to what is already done for the `printer` type.
Closed
lamawithonel
force-pushed
the
feature/default_printer_as_param
branch
from
99915a9 to
b816e19
Compare
Contributor
Author
|
I've updated this with a few additional changes I needed for my environment.
|
Owner
|
Thanks for the changes, will merge shortly. |
Contributor
Author
|
Thanks, and let me know if you need anything else, like rspec-puppet tests. |
mosen
added a commit
that referenced
this pull request
Sep 2, 2015
…aram Make default printer an exec configured w/ a param. Thanks @lamawithonel
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the
default_printertype and provider and makes it anexec instead, fed by a parameter to the init class. Using an exec like
this ensures the attribute remains singleton.