Skip to content

[ES-2889] [ES-2890] Updated client detail table with enc_public_key_cert#1648

Open
Md-Humair-KK wants to merge 1 commit intomosip:release-1.8.xfrom
Infosys:ES-2889On1.8.0
Open

[ES-2889] [ES-2890] Updated client detail table with enc_public_key_cert#1648
Md-Humair-KK wants to merge 1 commit intomosip:release-1.8.xfrom
Infosys:ES-2889On1.8.0

Conversation

@Md-Humair-KK
Copy link
Contributor

@Md-Humair-KK Md-Humair-KK commented Feb 26, 2026

Summary by CodeRabbit

  • Chores
    • Database infrastructure enhanced with updated schema to support improved encryption certificate storage and secure credential management. The system now securely processes additional encrypted credential data while maintaining compatibility with existing encryption mechanisms.
    • Configuration and deployment files improved with formatting updates for better maintainability.

Signed-off-by: Md-Humair-KK <mdhumair.kankudti@gmail.com>
@coderabbitai
Copy link

coderabbitai bot commented Feb 26, 2026

Walkthrough

Two database-related updates: a new column enc_public_key_cert (varchar(4000)) added to the client_detail table in the esignet DDL migration, and a formatting fix (newline appended) to the upgrade properties file.

Changes

Cohort / File(s) Summary
Database Schema
db_scripts/mosip_esignet/ddl/esignet-client_detail.sql
Added enc_public_key_cert column (varchar(4000)) to client_detail table for storing encrypted public key certificate.
Upgrade Configuration
db_upgrade_script/mosip_esignet/upgrade.properties
Added trailing newline to file for proper formatting; no functional changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A whisker-twitch of database grace,
New columns find their proper place,
With keys encrypted, safe and sound,
Where public certificates are found!
Newlines tidy, all is well—
A tale of schema we tell!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title clearly and concisely describes the main change: adding the enc_public_key_cert column to the client_detail table, which aligns perfectly with the actual changeset.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@zesu22 zesu22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check the review

@Md-Humair-KK Md-Humair-KK changed the title [ES-2889] [ES-2990] Updated client detail table with enc_public_key_cert [ES-2889] [ES-2890] Updated client detail table with enc_public_key_cert Mar 3, 2026
Copy link
Contributor

@zesu22 zesu22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants