Conversation
Signed-off-by: rajapandi1234 <138785181+rajapandi1234@users.noreply.github.com>
WalkthroughA new NOTICE file is introduced that catalogs third-party components and their associated licenses used by the project, organized by license category across MOSIP platform, e-signet, and SDK/utility libraries. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| THIRD-PARTY NOTICES | ||
|
|
||
| Copyright © MOSIP. | ||
| All rights reserved. | ||
|
|
||
| This project includes third-party components whose licenses require | ||
| attribution. The following components are included in this product. | ||
|
|
||
| =============================== | ||
| Mozilla Public License 2.0 | ||
| =============================== | ||
| • MOSIP Platform Components | ||
| (Kernel, ID Repository, Authentication Modules, Demographics & Biometrics APIs, | ||
| WebSub Client, Template Manager, ID Generators, Key Manager, CBEFF Utilities, | ||
| Data Access, OpenID Bridge APIs) | ||
|
|
||
| • MOSIP e-Signet Components | ||
| (esignet-core, esignet-integration-api) | ||
|
|
||
| • MOSIP SDKs & Utilities | ||
| (biosdk-client, demosdk, biometrics-util, testrig apitest commons) | ||
|
|
||
| =============================== | ||
| BSD / BSD-Style Licenses | ||
| =============================== | ||
| • PostgreSQL JDBC Driver | ||
| License: PostgreSQL License (BSD-style) | ||
|
|
||
| • OpenCV Java (org.openpnp:opencv) | ||
| License: BSD 3-Clause | ||
|
|
||
| =============================== | ||
| JSON License | ||
| =============================== | ||
| • JSON.org Library | ||
| License: JSON License (attribution required) | ||
|
|
||
| =============================== | ||
| MIT License | ||
| =============================== | ||
| • Project Lombok | ||
| • Mockito | ||
| • ByteBuddy | ||
| • Objenesis | ||
| • TensorFlow Java (MIT portions if applicable) | ||
|
|
||
| =============================== | ||
| Eclipse Public License | ||
| =============================== | ||
| • JUnit 4 (EPL-1.0) | ||
| • JUnit Vintage (EPL-2.0) | ||
| • H2 Database (EPL-1.0) | ||
|
|
||
| ------------------------------------------------------------ | ||
| Full license texts for these components are available in the | ||
| `license/` directory of this repository. | ||
| ------------------------------------------------------------ |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Check repository structure
echo "=== Repository Structure ==="
ls -la | head -20
echo -e "\n=== Looking for license directory ==="
find . -maxdepth 2 -name "license*" -type d
echo -e "\n=== Looking for dependency manifest files ==="
ls -la pom.xml build.gradle build.gradle.kts package.json 2>/dev/null || echo "No Maven/Gradle/NPM manifests found in root"
echo -e "\n=== Checking for NOTICE file location ==="
find . -name "NOTICE*" -type f | head -10
echo -e "\n=== Checking git files to understand structure ==="
git ls-files | grep -E "(pom.xml|build.gradle|package.json|NOTICE|LICENSE|license)" | head -20Repository: mosip/id-authentication
Length of output: 2014
🏁 Script executed:
#!/bin/bash
echo "=== THIRD-PARTY-NOTICES file ==="
head -100 THIRD-PARTY-NOTICES
echo -e "\n=== NOTICE file (for comparison) ==="
cat NOTICE
echo -e "\n=== Checking pom.xml files in subdirectories ==="
echo "authentication/pom.xml dependencies:"
head -50 authentication/pom.xmlRepository: mosip/id-authentication
Length of output: 8448
🏁 Script executed:
#!/bin/bash
echo "=== Checking for tensorflow in pom.xml files ==="
rg -i "tensorflow" . --type xml -A 2 -B 2
echo -e "\n=== Checking for spring dependencies in pom.xml files ==="
rg -i "spring" . --type xml | head -30
echo -e "\n=== Looking for all dependency references ==="
find . -name "pom.xml" -type f -exec grep -l "dependency" {} \;Repository: mosip/id-authentication
Length of output: 3810
Remove false reference to non-existent license/ directory and completely rebuild NOTICE with accurate, complete component listing.
The NOTICE file has critical issues:
-
Non-existent directory reference (lines 54-56): The statement "Full license texts for these components are available in the
license/directory" is false—no such directory exists in the repository. Remove or correct this reference. -
Severely incomplete component listing: The NOTICE omits the entire Apache License 2.0 section. Missing critical dependencies: Spring Boot, Spring Framework, Spring Cloud, Spring Kafka, Spring Batch, Spring Security, SpringDoc OpenAPI, Micrometer, Jackson, Apache Commons, Apache HttpComponents, Hibernate Validator, JSON Simple, and JSON Path.
-
License misclassification: TensorFlow Java is listed under "MIT License" but is actually distributed under Apache License 2.0 (confirmed in pom.xml and detailed in THIRD-PARTY-NOTICES).
-
Duplicate documentation: A comprehensive THIRD-PARTY-NOTICES file already exists with accurate licensing details. Consolidate or align these documents to avoid confusion about which is authoritative.
Either replace NOTICE with a complete, accurate listing (using THIRD-PARTY-NOTICES as reference) or remove it in favor of the existing comprehensive THIRD-PARTY-NOTICES file.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.