Added CA Certificate validity [MOSIP-43922]#759
Conversation
Signed-off-by: GOKULRAJ136 <110164849+GOKULRAJ136@users.noreply.github.com>
WalkthroughAdded and adjusted SQL migration scripts: updated symmetric crypto algorithm, introduced a new global parameter for CA certificate upload minimum validity, added/removed a CA_CERT_TYPE column in variant versioned scripts, and added corresponding rollback statements. Changes
Estimated Code Review Effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In
`@registration/registration-services/src/main/resources/sql/1.3.0/rollback_scripts.sql`:
- Around line 3-5: The WHERE clause uses inconsistent column identifier casing:
change the lowercase identifier in the delete statement to match the quoted
uppercase column name used elsewhere; update the delete from
"REG"."GLOBAL_PARAM" WHERE
code='mosip.kernel.partner.cacertificate.upload.minimumvalidity.month' to use
the same quoted identifier form as the UPDATE (i.e., "CODE") so both statements
consistently reference "CODE".
registration/registration-services/src/main/resources/sql/1.3.0/rollback_scripts.sql
Show resolved
Hide resolved
Signed-off-by: GOKULRAJ136 <110164849+GOKULRAJ136@users.noreply.github.com>
Summary by CodeRabbit