Skip to content

Conversation

@Demonmasterlqx
Copy link

@Demonmasterlqx Demonmasterlqx commented Nov 8, 2025

Description

  1. A point with a constant speed of 0 was added at the end of the trajectory to ensure safety
  2. Added the end_effector_frame parameter to moveit_servo and updated the Servo::toPlanningFrame(const TwistCommand& command, const std::string& planning_frame) function. The original code did not correctly implement the logic for apply_twist_commands_about_ee_frame. In the modified logic, if end_effector_frame is set and apply_twist_commands_about_ee_frame is true, the translational transformation is from command.frame to planning_frame, and the rotational transformation is from ee_frame to planning_frame.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@Demonmasterlqx Demonmasterlqx changed the title Fixed the behavior where moveit_servo did not wait for planing_sence to provide when it was not provided by the planing_sence provider FIX A point with a constant speed of 0 was added at the end of the trajectory to ensure safety Nov 8, 2025
@Demonmasterlqx Demonmasterlqx changed the title FIX A point with a constant speed of 0 was added at the end of the trajectory to ensure safety Adjusted the logic of the twist command of moveit_servo Nov 8, 2025
@Demonmasterlqx
Copy link
Author

@hihry @nbbrooks

Is there anything need to be down or any suggestion?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant