Skip to content

wait_for_job_completion: handle DEFERRED job statuses (bug 1986917) #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shtrom merged 3 commits into from
Sep 10, 2025
Merged

wait_for_job_completion: handle DEFERRED job statuses (bug 1986917) #14

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9d93de6
wait_for_job_completion: handle DEFERRED job statuses (bug 1986917)
shtrom Sep 10, 2025
20c5d32
wait_for_job_completion: show error that led to deferral (bug 1986917)
shtrom Sep 10, 2025
e68c136
fixup! wait_for_job_completion: show error that led to deferral (bug …
shtrom Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion lando_cli/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,9 @@ def post_actions(


def wait_for_job_completion(
config: Config, job_id: int, poll_interval: int = 3
config: Config,
job_id: int,
poll_interval: int = 3,
) -> dict:
"""Wait for a job to complete."""
click.echo("Waiting for job completion, you may exit at any time.")
Expand All @@ -158,6 +160,8 @@ def wait_for_job_completion(
+ "to check the status later."
)

previous_status = None

while True:
result = get_job_status(config, job_id)

Expand All @@ -167,6 +171,15 @@ def wait_for_job_completion(
click.echo("Job has been submitted and will be started soon.")
elif status == "IN_PROGRESS":
click.echo("Job is in progress.")
elif status == "DEFERRED":
if previous_status != "DEFERRED":
error_details = result.get("error", "No additional details provided.")
click.secho(
f"Job {job_id} was deferred, and will be retried.", fg="yellow"
)
click.echo(error_details)
else:
click.echo("Job was deferred and will be retried.")
elif status == "FAILED":
error_details = result.get("error", "No additional details provided.")
click.secho(f"Job {job_id} failed!", fg="red", bold=True)
Expand All @@ -187,6 +200,8 @@ def wait_for_job_completion(

time.sleep(poll_interval)

previous_status = status

return result


Expand Down