This repository was archived by the owner on May 29, 2021. It is now read-only.
Fixes #117 - The project does not compile with Xcode 12#118
Open
Fixes #117 - The project does not compile with Xcode 12#118
Conversation
st3fan
force-pushed
the
st3fan/modernize
branch
from
5b5b9f3 to
e9af913
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch brings the project up to date with Xcode 12. It now cleanly compiles except for two innocent warnings about simulator versions (for testing) in the AliSoftware/OHHTTPStubs framework.
Because AliSoftware/OHHTTPStubs had to be upgraded to a newer version, I used that as an opportunity to kick Carthage out of this project and instead us the Swift Package Manager. This makes the project simpler and more standard.
I also let Xcode upgrade the recommended project settings, but this included an upgrade of the
DEPLOYMENT_TARGETto12.0- Focus (the only consumer of this library) still deploys to11.4so I changed that back in the project.We can probably not land this until Focus is upgraded to Xcode 12.
Cc @boek