Update background.service_worker message #5838
Open
+16
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotproto
force-pushed
the
service-worker-message
branch
from
814d739 to
d255e92
Compare
Rob--W
reviewed
Oct 31, 2025
Comment on lines
+895
to
+896
| description: i18n._(`The "background" property must contain either "scripts" | ||
| or "page". See |
Member
There was a problem hiding this comment.
Instead of offering two options, let's offer "scripts" as a fallback. The MDN docs provides more context:
Suggested change
| description: i18n._(`The "background" property must contain either "scripts" | |
| or "page". See | |
| description: i18n._(`"background.scripts" must be specified as a fallback for | |
| "background.service_worker". See |
| this.collector.addWarning( | ||
| messages.manifestFieldUnsupported('/background/service_worker') | ||
| ); | ||
| this.collector.addWarning(messages.BACKGROUND_SERVICE_WORKER); |
Member
There was a problem hiding this comment.
I tried to come up with a message that is not confusing when used as a warning and an error. I cannot really think of a good one. Can we have a separate warning that is clear? Currently one would think that they did something wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5252
This PR updates the error/warning message returned when an extension's
manifest.jsonfile contains abackground.service_workerproperty without declaringbackground.scriptsorbackground.page.