Skip to content

[searchfox_api] Ignore the search results that are scattered in too many files #4854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+7 −0
Open

[searchfox_api] Ignore the search results that are scattered in too many files #4854

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dcf580b
[searchfox_api] Ignore the search results that are scattered in too m…
suhaibmujahid Feb 28, 2025
e71bcfc
Merge branch 'master' into paths-limit
suhaibmujahid Mar 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions bugbug/code_search/searchfox_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,13 @@ def search(commit_hash, symbol_name):
definitions.append(value)

paths = list(set(definition["path"] for definition in definitions))
if len(paths) > 10:
Copy link
Collaborator

@marco-c marco-c Apr 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How hard would it be to collect statistics about this? I guess we don't have an infrastructure in place for that, we should build it at some point

logger.warning(
"Too many paths found for symbol %s: %d paths. Skipping this symbol.",
symbol_name,
len(paths),
)
return []

return sum((get_functions(commit_hash, path, symbol_name) for path in paths), [])

Expand Down