This repository was archived by the owner on Apr 3, 2019. It is now read-only.
feat(basket): Make calls directly to basket server rather than the proxy#7050
Open
shane-tomlinson wants to merge 1 commit intomasterfrom
Open
feat(basket): Make calls directly to basket server rather than the proxy#7050shane-tomlinson wants to merge 1 commit intomasterfrom
shane-tomlinson wants to merge 1 commit intomasterfrom
Conversation
ghost
assigned
shane-tomlinson
force-pushed
the
7048-remove-basket-proxy
branch
3 times, most recently
from
993b1ad to
5016832
Compare
Author
|
@mozilla/fxa-devs, @jrgm - r? |
shane-tomlinson
changed the title
philbooth
reviewed
Mar 27, 2019
server/lib/configuration.js
Outdated
| api_timeout: { | ||
| default: '5 seconds', | ||
| doc: 'Timeout for talking to the Basket API server, in ms', | ||
| format: Number |
Contributor
There was a problem hiding this comment.
Should this be format: 'duration' ?
Author
There was a problem hiding this comment.
I just copied this these over, but that seems like a fine suggestion while I'm in here making updates.
philbooth
approved these changes
Mar 27, 2019
…e proxy Note: configuration under the basket namespace were merged into the marketing_email namespace, there doesn't seem to be a good reason for both namespaces to exist. fixes #7048 BREAKING CHANGE
shane-tomlinson
force-pushed
the
7048-remove-basket-proxy
branch
from
5016832 to
263d343
Compare
Author
|
This repo has been deprecated and migrated to https://github.com/mozill/fxa. Please open this PR against that repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: configuration under the basket namespace were merged into the marketing_email namespace,
there doesn't seem to be a good reason for both namespaces to exist.
fixes #7048
BREAKING CHANGE - this may require changes to fxa-dev or cloudops-deployment to migrate any config items under the
basketnamespace.