fix(style): set line-height to improve global body legibility#722
fix(style): set line-height to improve global body legibility#722shane-tomlinson merged 1 commit intomozilla:masterfrom
Conversation
|
@ryanfeeley review please |
shane-tomlinson
left a comment
There was a problem hiding this comment.
Thanks for this @karansapolia and I'm sorry for the delay in reviewing.
Using the generic p selector will apply this everywhere and that will most definitely break the layout in a lot of places. @ryanfeeley's original bug specifies:
Would love to see this applied to our terms of service, and privacy policy (24px line height).
That bug shows the altered line height applied to the cookies_disabled page.
Ryan also suggests using a 24px line height on the terms of service and privacy policy.
One final place where it might make sense is the update firefox template.
Can you make the selectors specific for now, we can try to make things more general in the future, but that's not a task I think you should take on here because it's could be a doozy ensuring everything looks just as it should.
Done. @shane-tomlinson r+? Would also request you to rerun the tests. |
packages/fxa-content-server/app/styles/modules/_update_firefox.scss
Outdated
Show resolved
Hide resolved
shane-tomlinson
left a comment
There was a problem hiding this comment.
r+, thanks @karansapolia!
fixes #591
continuation of mozilla/fxa-content-server#7079