fix(emails): Make Done button responsive after adding email#723
Closed
karansapolia wants to merge 1 commit intomozilla:masterfrom
Closed
fix(emails): Make Done button responsive after adding email#723karansapolia wants to merge 1 commit intomozilla:masterfrom
karansapolia wants to merge 1 commit intomozilla:masterfrom
Conversation
Contributor
Author
|
@ryanfeeley is this needed? or is the current behavior preferred? |
shane-tomlinson
suggested changes
Apr 11, 2019
Contributor
shane-tomlinson
left a comment
shane-tomlinson
left a comment
There was a problem hiding this comment.
@karansapolia - this behavior is much better! Can you do one little additional bit of cleanup, and I think we can merge this. hasSecondaryVerifiedEmail is no longer used by the template, can you remove it from the list of fields to pass to the template?
After adding new email in secondary email section, make the done button responsive before email verification. Allow done button to be clicked and panel to be closed. Do not change the behavior of automatically opening panel if secondary linked email is unverified. fixes: mozilla#626
karansapolia
force-pushed
the
fix-button-626
branch
from
cdae793 to
f74ce9b
Compare
Contributor
Author
|
With reference to @ryanfeeley's comment, I think we should close this PR and also issue #626. |
Contributor
|
From #723 (comment), we can close this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After adding new email in secondary email section, make
the done button responsive before email verification. Allow
done button to be clicked and panel to be closed. Do not
change the behavior of automatically opening panel if
secondary linked email is unverified.
fixes: #626
continuation of mozilla/fxa-content-server#7092