-
Notifications
You must be signed in to change notification settings - Fork 27
add config for frecency experiment #1273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
mikewilli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left one specific comment on a change I know you'll need. There are some other issues here that you'll likely be able to find yourself and fix once jetstream preview is fixed in mozilla/jetstream#2936, but the problem is with the total_tile_third* and sponsored_tile* metrics -- metric-config-parser is saying some of them are missing statistics.
Co-authored-by: Mike Williams <102263964+mikewilli@users.noreply.github.com>
|
For posterity: As far as @jaredsnyder and I could tell, the order in which metrics were defined in the daily/weekly/overall lists made a difference in whether the config resolved properly (see this commit), at least for the metrics that depend on others. This appears to be because the parser just pulls in and resolves the metrics in the order they're defined, and so if the downstream metric is in the list before its dependencies, those dependent metrics don't exist as far as the parser knows. I also filed this ticket #1295 |
Doc: https://docs.google.com/document/d/1gJfx8ITCwBOuy2BiRux_fATgAYW1UxZicAbIcYFdNJc/edit?tab=t.erl2a62ns55c