Skip to content

Conversation

@jaredsnyder
Copy link
Contributor

Copy link
Collaborator

@mikewilli mikewilli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left one specific comment on a change I know you'll need. There are some other issues here that you'll likely be able to find yourself and fix once jetstream preview is fixed in mozilla/jetstream#2936, but the problem is with the total_tile_third* and sponsored_tile* metrics -- metric-config-parser is saying some of them are missing statistics.

Co-authored-by: Mike Williams <102263964+mikewilli@users.noreply.github.com>
@mikewilli
Copy link
Collaborator

For posterity:

As far as @jaredsnyder and I could tell, the order in which metrics were defined in the daily/weekly/overall lists made a difference in whether the config resolved properly (see this commit), at least for the metrics that depend on others. This appears to be because the parser just pulls in and resolves the metrics in the order they're defined, and so if the downstream metric is in the list before its dependencies, those dependent metrics don't exist as far as the parser knows.

I also filed this ticket #1295

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants