-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[Editor] Eraser editor and eraser button to be able to erase annotations #20227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
legraina
wants to merge
14
commits into
mozilla:master
Choose a base branch
from
lab-core:eraser
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me, until the user changes the mode.
… eraseable implemented. It behaves as a rubber when erasing writting.
Contributor
Author
|
Hi @calixteman and @timvandermeij, I have merged the changes, and this PR is working correctly. However, I know it's a bigger PR than the previous ones. I was wondering if you have any idea on how long it will take to merge it. I would perhaps planned for alternatives based on your answer. Thanks a lot for your work. |
6255ec9 to
601f1a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have created an eraser button to be able to erase annotations. The goal of this eraser is to remove parts of some annotations (which are erasable), especially the ink annotations. When you write, in particular on a tablet, you may want to erase parts of your writing, it’s where this eraser comes in play, like a real eraser/rubber. There is nothing added to the document it-self, as it just modifies current annotations. It replaces closed PR #20192.