Skip to content
This repository was archived by the owner on Dec 1, 2025. It is now read-only.

Refactor tlsobs main routine.#428

Open
bernata wants to merge 1 commit intomozilla:masterfrom
bernata:refactor-tlsobs-scan
Open

Refactor tlsobs main routine.#428
bernata wants to merge 1 commit intomozilla:masterfrom
bernata:refactor-tlsobs-scan

Conversation

@bernata
Copy link

@bernata bernata commented Aug 15, 2021

Invoke postScan to post to scan endpoint instead of having the code inline.
Added tests for postScan and building url to scan endpoint.

Checklist

  • Run make, gofmt and golint your code, and run a test scan on your local machine before submitting for review.
  • Workers needs an AnalysisPrinter, registered via worker.RegisterPrinter() (which is separate from worker.RegisterWorker()), and imported in tlsobs (example).
  • When adding new columns to the database, also add a DB migration script under database/migrations named the next release (eg. if current release is 1.3.2, migration file will be 1.3.3.sql).
  • When new columns require data to be recomputed, add a script under /tools (example) that updates the database and will be run by administrators.

Invoke `postScan` to post to scan endpoint instead of having the code inline.
Added tests for postScan and building url to scan endpoint.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant