WT-856 Use Translated Text In Get/Download Firefox Buttons by dchukhin · Pull Request #1132 · mozmeao/springfield

dchukhin · 2026-03-09T19:03:12Z

One-line summary

This pull request tries to use already-created translations for "Get Firefox" and "Download Firefox" buttons by rendering the text with ftl strings.

Significant changes and points to review

In order to not send the same text for translation from multiple places, we now have a FluentOrCustomTextBlock, which allows users to choose some pretranslated text ("Get Firefox", "Download Firefox"), or use custom text:

the FluentOrCustomTextBlock is used in the DownloadFirefoxButtonBlock
all previously created DownloadFirefoxButtonBlocks have had their text mapped to the new choices
similarly to the new block, the PreFooterCTASnippet now has a custom_label field for custom text that will be translated. Its label field has been renamed to pretranslated_label, and shows the same pre-translated choices as the FluentOrCustomTextBlock. Choosing "Custom text" allows the user to enter custom text that will be sent for translation.

Issue / Bugzilla link

WT-856

Testing

log in to Wagtail, and find a page that uses the pre-footer snippet. For example, localhost:8000. Observe the value in the (non-firefox) template.
change the value of the pre-footer call to action snippet to a pre-translated choice and view the page in en-US. Observe the updated label.
change the value of the pre-footer call to action snippet to custom text and view the page in en-US. Observe the updated label.
change the value of the es-MX pre-footer call to action snippet to a pre-translated choice and view the page in es-MX. Observe the updated label.
change the value of the pre-footer call to action snippet to custom text and view the page in es-MX. Observe the updated label.
Find a page that uses the download firefox button, and set the text value to be one of the pre-translated choices (for example, "Download Firefox"). Observe that the text in the template. Set another download button text to be some custom text.
translate the page and observe that "Download Firefox" is not one of the translatable text fields, but it is already translated in the template. Observe that your custom text is one of the translatable text fields, and is not translated in the template.
note that none of the pre-translated values should be sent for translation

…s or strings that need translation

…ew PreFooterCTASnippet label fields

…d-firefox-buttons

codecov · 2026-03-09T21:14:23Z

Codecov Report

❌ Patch coverage is 43.24324% with 126 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.30%. Comparing base (9d2cc6c) to head (7adf009).

Files with missing lines	Patch %	Lines
...agement/commands/migrate_download_button_labels.py	27.58%	126 Missing ⚠️

Additional details and impacted files

@@                          Coverage Diff                           @@
##           WT-854-language-fallback-for-pages    #1132      +/-   ##
======================================================================
- Coverage                               79.24%   78.30%   -0.95%     
======================================================================
  Files                                     133      134       +1     
  Lines                                    8383     8600     +217     
======================================================================
+ Hits                                     6643     6734      +91     
- Misses                                   1740     1866     +126

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…d-firefox-buttons

maribedran · 2026-03-11T20:45:45Z

springfield/cms/migrations/0058_migrate_download_button_labels.py

+
+
+def convert_pages(apps, schema_editor):
+    models_and_fields = [


This list needs to be updated with the new free form page 2026

maribedran · 2026-03-11T20:47:39Z

springfield/cms/migrations/0058_migrate_download_button_labels.py

+            except (json.JSONDecodeError, TypeError):
+                pass
+        if modified:
+            revision.save(update_fields=["content"])


Missing the other field names

maribedran · 2026-03-11T20:48:49Z

springfield/cms/migrations/0058_migrate_download_button_labels.py

+    from django.contrib.contenttypes.models import ContentType
+
+    page_models = [
+        apps.get_model("cms", name) for name in ("HomePage", "DownloadPage", "ThanksPage", "ArticleThemePage", "FreeFormPage", "WhatsNewPage")


springfield/cms/blocks.py

- include FreeFormPage2026 in models being updated - make sure convert_revisions reads the appropriate locale and runs only for relevant page types - preserve non-English snippet custom labels

we avoid an error even if some CharFields have a None value by forcing None values to be ''

…he text

…d-firefox-buttons

…nagement command

…d-firefox-buttons

dchukhin added 15 commits March 6, 2026 12:21

add a FluentOrCustomTextBlock to support either pre-translated string…

d2a8489

…s or strings that need translation

add the option to use pretranslated text on the PreFooterCTASnippet

bd0b7d2

use FluentOrCustomTextBlock in the DownloadFirefoxButtonBlock

d505035

update ftl string references for already-existing strings

d660d6b

update ftl string references for already-existing strings

6c98b7b

migrate data for old label fields to new FluentOrCustomTextBlock or n…

5cf7382

…ew PreFooterCTASnippet label fields

remove deprecated field

ea6e0b7

update templates to use new fields

a77883b

update tests based on field changes

7062d23

update fixtures based on field changes

90f2e3a

Merge branch 'main' into WT-856-download-firefox-buttons

ff69845

hide 'Custom text' field if the text type is not 'Custom text'

385721c

Merge branch 'main' into WT-856-download-firefox-buttons

0cfe1d3

add help_text to FluentOrCustomTextBlock.pretranslated_or_custom field

d1e443c

Merge branch 'WT-854-language-fallback-for-pages' into WT-856-downloa…

3ff4d6e

…d-firefox-buttons

dchukhin marked this pull request as draft March 9, 2026 20:49

dchukhin added 2 commits March 11, 2026 16:25

Merge branch 'WT-854-language-fallback-for-pages' into WT-856-downloa…

4d477a4

…d-firefox-buttons

reorder migrations after merge

4dc3211

maribedran reviewed Mar 11, 2026

View reviewed changes

dchukhin added 10 commits March 12, 2026 09:18

Merge branch 'main' into WT-856-download-firefox-buttons

dab2ce0

improve logic of data migration

b487df6

- include FreeFormPage2026 in models being updated - make sure convert_revisions reads the appropriate locale and runs only for relevant page types - preserve non-English snippet custom labels

make sure we successfully update translation sources

54b2f14

we avoid an error even if some CharFields have a None value by forcing None values to be ''

make sure live pages do not require actions to see updated button text

58bb209

update help text to be more explicit about translations of the text

6e2fe14

move logic to update download button data into a management command

bdbcc9a

update snippter help text to be more explicit about translations of t…

1b092a8

…he text

update test file to point to updated code

508754c

Merge branch 'WT-854-language-fallback-for-pages' into WT-856-downloa…

cdb160a

…d-firefox-buttons

choosing 'Custom Text' requires filling in some custom text

dde620f

dchukhin added 3 commits March 12, 2026 15:10

avoid comparing to a hard-coded constant value across the codebase

c723b61

Merge branch 'WT-854-language-fallback-for-pages' into WT-856-downloa…

f5877c9

…d-firefox-buttons

add a data migration that calls the migrate_download_button_labels ma…

fc0c95a

…nagement command

maribedran approved these changes Mar 16, 2026

View reviewed changes

dchukhin added 2 commits March 19, 2026 13:40

Merge branch 'WT-854-language-fallback-for-pages' into WT-856-downloa…

a9fd303

…d-firefox-buttons

reorder migrations after merge

7adf009

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WT-856 Use Translated Text In Get/Download Firefox Buttons#1132

WT-856 Use Translated Text In Get/Download Firefox Buttons#1132
dchukhin wants to merge 32 commits intoWT-854-language-fallback-for-pagesfrom
WT-856-download-firefox-buttons

dchukhin commented Mar 9, 2026

Uh oh!

codecov bot commented Mar 9, 2026 •

edited

Loading

Uh oh!

maribedran Mar 11, 2026

Uh oh!

maribedran Mar 11, 2026

Uh oh!

maribedran Mar 11, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants



		def convert_pages(apps, schema_editor):
		models_and_fields = [

Conversation

dchukhin commented Mar 9, 2026

One-line summary

Significant changes and points to review

Issue / Bugzilla link

Testing

Uh oh!

codecov bot commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

maribedran Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

maribedran Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

maribedran Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov bot commented Mar 9, 2026 •

edited

Loading