feat: Add custom event logging for selectplacements#113
Merged
Mansi-mParticle merged 3 commits intomainfrom Jan 29, 2026
Merged
feat: Add custom event logging for selectplacements#113Mansi-mParticle merged 3 commits intomainfrom
Mansi-mParticle merged 3 commits intomainfrom
Conversation
jamesnrokt
reviewed
Jan 12, 2026
Collaborator
|
There may be value is separating custom attributes to show what a developer passed in vs what we add to the ultimate selectPlacements call. I am meeting with the GTM team to discuss and will follow up. |
1 task
jamesnrokt
previously approved these changes
Jan 16, 2026
77638ba to
c9e2b00
Compare
rmi22186
reviewed
Jan 29, 2026
c9e2b00 to
b21f0a1
Compare
thomson-t
approved these changes
Jan 29, 2026
rmi22186
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instructions
developmentSummary
The attributes passed to selectPlacement are added as custom attributes to the MPEvent, which is logged using EventType.Other.
Testing Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)