ci: SDKE-548 add CI/CD and semantic release#50
Merged
rmi22186 merged 5 commits intomparticle-integrations:masterfrom Nov 12, 2025
Merged
Conversation
rmi22186
reviewed
Nov 12, 2025
release.config.js
Outdated
Collaborator
There was a problem hiding this comment.
Suggested change
| assets: ['dist/FacebookEventForwarder.common.js', 'dist/FacebookEventForwarder.iife.js'], | |
| assets: ['dist/FacebookEventForwarder.common.js', 'dist/FacebookEventForwarder.iife.js', 'FacebookEventForwarder.esm.js'], |
Collaborator
There was a problem hiding this comment.
you wouldn't have known this, but I was looking in our commit history and looks like someone added the ESM module to the rollup config as an output, so we should include it. this is something we should do for all our other kits as well.
Contributor
Author
There was a problem hiding this comment.
Sure, I'll review the other kits for ESM outputs and open Sustained Engineering tickets for any that are missing it
rmi22186
requested changes
Nov 12, 2025
Collaborator
rmi22186
left a comment
There was a problem hiding this comment.
one minor comment but otherwise LGTM.
rmi22186
approved these changes
Nov 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instructions
developmentSummary
Testing Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)