Skip to content

Fix setting rbsp_trailing_bits and Unregistered User Data SEI payload_size #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dariusz-f merged 2 commits into from
Feb 24, 2026
Merged

Fix setting rbsp_trailing_bits and Unregistered User Data SEI payload_size #159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6efaff0
Fix setting Unregistered User Data SEI payload_size
jamrial Feb 24, 2026
6d52a2b
Fix writing rbsp_trailing_bits()
jamrial Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src_base/xeve_eco.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,7 @@ int xeve_eco_sps(XEVE_BSW *bs, XEVE_SPS *sps)
}

u32 t0 = 0;
xeve_bsw_write1(bs, 1);
while(!XEVE_BSW_IS_BYTE_ALIGN(bs)) {
xeve_bsw_write1(bs, t0);
}
Expand Down Expand Up @@ -235,6 +236,7 @@ int xeve_eco_pps(XEVE_BSW *bs, XEVE_SPS *sps, XEVE_PPS *pps)
xeve_bsw_write_ue(bs, pps->cu_qp_delta_area - 6);
}
u32 t0 = 0;
xeve_bsw_write1(bs, 1);
while(!XEVE_BSW_IS_BYTE_ALIGN(bs)) {
xeve_bsw_write1(bs, t0);
}
Expand Down Expand Up @@ -331,7 +333,7 @@ static void write_sei_userdata_unregistered(XEVE_SEI_PAYLOAD *sei_userdata, XEVE
xeve_bsw_write(bs, 0xff, 8);
xeve_bsw_write(bs, payload_type, 8);

u32 payload_size = (ISO_IEC_11578_LEN + sei_userdata->payload_size) << 3;
u32 payload_size = ISO_IEC_11578_LEN + sei_userdata->payload_size;
for(; payload_size >= 0xff; payload_size -= 0xff)
xeve_bsw_write(bs, 0xff, 8);
xeve_bsw_write(bs, payload_size, 8);
Expand Down Expand Up @@ -368,6 +370,7 @@ int xeve_eco_emitsei(XEVE_CTX *ctx, XEVE_BSW *bs)
write_sei_userdata_unregistered(&sei_userdata_unregistered, bs);
}

xeve_bsw_write1(bs, 1);
while(!XEVE_BSW_IS_BYTE_ALIGN(bs)) {
xeve_bsw_write1(bs, 0);
}
Expand All @@ -382,6 +385,7 @@ int xeve_eco_sei(XEVE_CTX *ctx, XEVE_BSW *bs)
xeve_eco_signature(ctx, bs);
}

xeve_bsw_write1(bs, 1);
while(!XEVE_BSW_IS_BYTE_ALIGN(bs)) {
xeve_bsw_write1(bs, 0);
}
Expand Down
3 changes: 3 additions & 0 deletions src_main/xevem_eco.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,6 +263,7 @@ int xevem_eco_aps_gen(XEVE_BSW *bs, XEVE_APS_GEN *aps, int bit_depth)
assert(aps_extension_flag == 0);

u32 t0 = 0;
xeve_bsw_write1(bs, 1);
while(!XEVE_BSW_IS_BYTE_ALIGN(bs)) {
xeve_bsw_write1(bs, t0);
}
Expand Down Expand Up @@ -423,6 +424,7 @@ int xevem_eco_sps(XEVE_BSW *bs, XEVE_SPS *sps)
}

u32 t0 = 0;
xeve_bsw_write1(bs, 1);
while(!XEVE_BSW_IS_BYTE_ALIGN(bs)) {
xeve_bsw_write1(bs, t0);
}
Expand Down Expand Up @@ -486,6 +488,7 @@ int xevem_eco_pps(XEVE_BSW *bs, XEVE_SPS *sps, XEVE_PPS *pps)
xeve_bsw_write_ue(bs, pps->cu_qp_delta_area - 6);
}
u32 t0 = 0;
xeve_bsw_write1(bs, 1);
while(!XEVE_BSW_IS_BYTE_ALIGN(bs)) {
xeve_bsw_write1(bs, t0);
}
Expand Down