Configure the ChiSqSelector to reuse ChiSqTestResult by numTopFeature, Percentile and Fpr selector#2
Open
mpjlu wants to merge 9 commits intofprChiSquarefrom
Open
Configure the ChiSqSelector to reuse ChiSqTestResult by numTopFeature, Percentile and Fpr selector#2mpjlu wants to merge 9 commits intofprChiSquarefrom
mpjlu wants to merge 9 commits intofprChiSquarefrom
Conversation
|
It could make this PR clearer to set the base as master the branch without any change you commit. |
added 2 commits
August 17, 2016 10:34
| def setNumTopFeatures(value: Int): this.type = set(numTopFeatures, value) | ||
| def setNumTopFeatures(value: Int): this.type = { | ||
| chiSqSelector.setNumTopFeatures(value) | ||
| chiSqSelector.setChiSqSelectorType(ChiSqSelectorType.KBest) |
There was a problem hiding this comment.
Is setChiSqSelectorType called twice here?
mpjlu
force-pushed
the
fprChiSquare
branch
2 times, most recently
from
128fcd7 to
e28a8c5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Configure the ChiSqSelector to reuse ChiSqTestResult by numTopFeature, Percentile and Fpr selector,
This is the initial version, I will add annotation for the functions and vars.
Maybe some more examples.
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
…s, Percentile, and Fpr selector