Fix NFQ verdict failure by converting packet ID to host byte order#381
Open
lfking wants to merge 1 commit intomrash:masterfrom
Open
Fix NFQ verdict failure by converting packet ID to host byte order#381lfking wants to merge 1 commit intomrash:masterfrom
lfking wants to merge 1 commit intomrash:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The nfq_set_verdict function in libnetfilter_queue expects the
packet ID in Host Byte Order, as it performs its own internal
conversion to Network Byte Order (Big-Endian).
The current implementation was passing the raw Big-Endian ID
retrieved from the header directly to the library. On Little-Endian
architectures (x86_64), this resulted in a double-swap, causing
the kernel to reject verdicts with ENOENT and eventually leading
to NFQUEUE saturation and daemon silence.
This fix wraps ph->packet_id in ntohl() to ensure the library
receives the ID in the expected Host Byte Order.