prep --check: Add support to spellcheck is codespell is installed#68
Open
marcosps wants to merge 1 commit intomricon:masterfrom
Open
prep --check: Add support to spellcheck is codespell is installed#68marcosps wants to merge 1 commit intomricon:masterfrom
marcosps wants to merge 1 commit intomricon:masterfrom
Conversation
This commit add --codespell to checkpatch.pl is the codespell package is install. If b4 is installed with pipx you need to use --system-site-packages when calling install, otherwise it won't see the packages installed by your package manager. Signed-off-by: Marcos Paulo de Souza <mpdesouza@suse.com>
Contributor
Author
|
@mricon ping :) |
|
From: #62 (comment)
Also from: 220ba25
Using b4 to send b4 patches is not a shocking demand :-D (I was wondering about exactly that) |
Contributor
Author
|
@marc-hb never thought about it, but really makes sense. Just sent the patch, thanks for letting me know :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit add --codespell to checkpatch.pl is the codespell package is install.
If b4 is installed with pipx you need to use --system-site-packages when calling install, otherwise it won't see the packages installed by your package manager.
@mricon this new feature was added since I forgot to run checkpatch.pl --codespell when sending the patch to the ML. I believed that b4 would do such check, but I was mistaken. What do you think about it?