Upgraded the app to rely on create-react-app and reactstrap. #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gentilboulet
force-pushed
the
improvement/create-react-app
branch
from
3d554e8 to
4f12e6a
Compare
gentilboulet
force-pushed
the
improvement/create-react-app
branch
from
4f12e6a to
8a53adb
Compare
mropert
requested changes
Jul 23, 2017
Owner
mropert
left a comment
mropert
left a comment
There was a problem hiding this comment.
Also, why are we keeping the main.jsx.old file?
| @@ -1,22 +0,0 @@ | |||
| module.exports = { | |||
Owner
There was a problem hiding this comment.
Removing this file seems to disable eslint completely in Atom
| install: | ||
| - npm install -g gulp | ||
| - npm install | ||
| script: gulp build |
Owner
There was a problem hiding this comment.
Shouldn't we also run a build? The linter?
mropert
reviewed
Jul 23, 2017
| "react-dom": "^15.6.1", | ||
| "react-icons": "^2.2.5", | ||
| "react-redux": "^5.0.5", | ||
| "reactstrap": "^4.8.0", |
Owner
There was a problem hiding this comment.
Looks like the switch also removed some CSS padding / margin.
If you look at before/after, the UI renders boxes without any.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an "s" to some directories.
Upgraded from Glyphicons to FontAwesome.