Latest and greatest #10
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madness? THIS IS SPARTA
don’t actually need to define variants first for `char_to_unified` because unlike `Scanner.bscan/1`, this is matching against an entire binary rather than just head, so no need to worry about similar out of order issues.
One or all of these emoji #⃣ #️⃣ *⃣ were causing:
== Compilation error on file lib/exmoji/scanner.ex ==
** (Regex.CompileError) nothing to repeat at position 5795
(elixir) lib/regex.ex:142: Regex.compile!/2
lib/exmoji/scanner.ex:43: (module)
(stdlib) erl_eval.erl:670: :erl_eval.do_apply/6
Prior to this commit exmoji used the old `\x{H*}` format for unicode
escape sequences, which generates warnings with Elixir 1.3. This commit
updates those escape sequences to use the preferred `\xHH` and `\uHHHH`
formats.
Collaborator
|
Recreated and updated in https://github.com/mroth/exmoji/pull/32/files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #1, closes #8, and closes #9 by merging them all together and resolving conflicts.