fix: add academic/ and sales/ to lint-agents.sh and CI workflow#243
Open
Astro-Han wants to merge 1 commit intomsitarzewski:mainfrom
Open
fix: add academic/ and sales/ to lint-agents.sh and CI workflow#243Astro-Han wants to merge 1 commit intomsitarzewski:mainfrom
Astro-Han wants to merge 1 commit intomsitarzewski:mainfrom
Conversation
academic/ was added in msitarzewski#219 but lint-agents.sh AGENT_DIRS and the CI workflow paths/diff-filter were not updated. sales/ was covered by CI but missing from lint-agents.sh local full-scan. Fixes msitarzewski#242
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds the
academic/andsales/directories toscripts/lint-agents.shAGENT_DIRSand addsacademic/to the.github/workflows/lint-agents.ymltrigger paths and diff filter, so these directories are covered by both local full-scan linting and CI.Why
academic/was added in #219 withconvert.shandinstall.shupdates, but the linter and CI workflow were not updated — PRs touchingacademic/agents never trigger CI lint.sales/was already in CI but missing fromlint-agents.sh, so local./scripts/lint-agents.sh(no args) silently skipped it.Directory ordering in
AGENT_DIRSnow matchesconvert.shandinstall.sh.Fixes #242
Checklist
./scripts/lint-agents.sh→ 0 errors, 156 files scanned (previously missed academic/ and sales/)