refactor: sync agent directory lists across all scripts#253
Open
BloodShop wants to merge 1 commit intomsitarzewski:mainfrom
Open
refactor: sync agent directory lists across all scripts#253BloodShop wants to merge 1 commit intomsitarzewski:mainfrom
BloodShop wants to merge 1 commit intomsitarzewski:mainfrom
Conversation
The three scripts (convert.sh, install.sh, lint-agents.sh) each maintained their own hardcoded list of agent category directories, which had drifted out of sync: - lint-agents.sh was missing: academic, sales, strategy - convert.sh was missing: strategy - install.sh duplicated the dir list inline in two functions Changes: - Add missing directories to all three scripts - Sort entries alphabetically for easier maintenance - Extract a shared AGENT_DIRS constant in install.sh (replaces two identical inline lists in install_claude_code and install_copilot) - Add a comment reminding maintainers to keep the lists in sync No behavioral changes for directories that already existed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The three shell scripts each maintained their own hardcoded list of agent category directories, which had drifted out of sync. This caused some agent categories to be silently skipped during linting, conversion, or installation.
Problem
convert.shinstall.shlint-agents.shacademic/sales/strategy/This means:
lint-agents.shnever linted agents inacademic/,sales/, orstrategy/convert.shnever converted agents instrategy/install.shnever installed agents fromstrategy/Changes
1. Add missing directories to all three scripts
All scripts now include the same 14 directories, sorted alphabetically:
2. Extract shared
AGENT_DIRSconstant ininstall.shPreviously,
install_claude_code()andinstall_copilot()each had their own identical inline directory list. Now both reference a singleAGENT_DIRSarray, matching the pattern already used byconvert.shandlint-agents.sh.3. Sort entries alphabetically
Makes it trivial to spot missing entries when new directories are added.
Files Changed
scripts/lint-agents.shacademic,sales,strategy; sorted entriesscripts/convert.shstrategy; sorted entriesscripts/install.shAGENT_DIRSconstant; addedstrategy; replaced 2 inline loopsImpact
academic/,sales/, andstrategy/will now be properly linted, converted, and installedAGENT_DIRSarray)Testing