feat: Add cross-platform file locking for Windows #152
Open
Kevin-CNC wants to merge 1 commit intomsoulier:masterfrom
Open
feat: Add cross-platform file locking for Windows #152Kevin-CNC wants to merge 1 commit intomsoulier:masterfrom
Kevin-CNC wants to merge 1 commit intomsoulier:masterfrom
Conversation
|
Thanks @Kevin-CNC, this has worked great for us on Windows. Is there any chance that this might enter |
|
@JoelBowring-Hover Did you try the latest commit on master? It should work on windows, I'm just trying to get the test suite working properly on both platforms. |
|
@msoulier-mitel I tested the latest commit on Windows 11. All working for me in my application. |
|
@msoulier-mitel Sorry for the delay - yes, the latest commit also worked for us on Windows. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressed issue #148 about the module using fcntl via custom-made lock system. Tested & was able to load with no issue & operate within a local TFTP server. Hope this works for you :)